Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughModified the GitHub Actions release workflow to use NPM provenance for package publishing. Added explicit permissions for the release job (contents, id-token, issues, pull-requests) and an environment variable enabling NPM provenance configuration. Removed direct NPM_TOKEN secret reference from the release step environment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 63.14% 63.26% +0.12%
==========================================
Files 21 21
Lines 605 607 +2
Branches 228 230 +2
==========================================
+ Hits 382 384 +2
Misses 182 182
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 17.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Updated the
releasejob invalidate.ymlto support npm trusted publishers.Why:
To enable publishing packages with provenance information using OIDC, enhancing security by removing the reliance on long-lived
NPM_TOKENsecrets. This aligns with modern best practices for npm publishing.How:
permissionsto thereleasejob, includingid-token: writefor OIDC.NPM_CONFIG_PROVENANCE: 'true'in thereleasejob's environment.NPM_TOKENfrom thesemantic-release-actionstep's environment.Checklist:
Note
Medium Risk
Changes the release pipeline’s auth mechanism and permissions; misconfiguration could break publishing or broaden GitHub token capabilities, but scope is limited to CI.
Overview
Updates the GitHub Actions
releasejob to publish via npm Trusted Publishers/OIDC by grantingid-token: writeand enabling npm provenance (NPM_CONFIG_PROVENANCE: 'true').Removes use of the long-lived
NPM_TOKENsecret from thesemantic-releasestep, relying on workflow permissions for release/publishing-related actions instead.Written by Cursor Bugbot for commit 522854a. This will update automatically on new commits. Configure here.
Summary by CodeRabbit