Add the ability to create keys from certificate private keys#5
Open
pschou wants to merge 12 commits intokayrus:masterfrom
Open
Add the ability to create keys from certificate private keys#5pschou wants to merge 12 commits intokayrus:masterfrom
pschou wants to merge 12 commits intokayrus:masterfrom
Conversation
…ncrypt with a password, and marshal the result
Owner
|
Thanks for the PR. It's quite a big change and I need a bigger free time slot to review it. |
kayrus
reviewed
Sep 18, 2022
Owner
kayrus
left a comment
kayrus
left a comment
There was a problem hiding this comment.
See the first code review. The rest will submit later.
Author
|
@kayrus I am sorry for the |
Author
|
@kayrus: Just a heads up here, I finished implementing the SSH1 read and writing routines, so this library can thoroughly read and write every possible putty key format! All the best! |
Owner
|
@pschou I apologies for the delay. Could you please rebase your branch to resolve the conflicts? I'll try to review this PR ASAP. |
kayrus
force-pushed
the
master
branch
4 times, most recently
from
00f4caf to
4ee737f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows your tool to create ppk files from a given private key. I also rounded out the ability to read, write, and verify all the putty version formats (SSH1 1.1, and the more current 1,2, and 3).