added tanh nonlinearity function to engine.py#74
Open
Naren219 wants to merge 1 commit intokarpathy:masterfrom
Open
added tanh nonlinearity function to engine.py#74Naren219 wants to merge 1 commit intokarpathy:masterfrom
Naren219 wants to merge 1 commit intokarpathy:masterfrom
Conversation
TheMattBin
approved these changes
Jun 23, 2024
|
This implementation is numerically unstable. For large x e.g. x=1000 it will cause the following error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i found out that tanh wasn't implemented in the repo so I copied Karpathy's code from the video to the value class as a method.
using this nonlinearity function should allow you to train better with negative numbers (found this out the hard way by trying to replicate the video dataset with relu instead and my loss was so high).
hope this helps!
-naren