Open
Conversation
On the iPhone X / XS, the cropView and fadeView were not perfectly on top of each other (offset in y direction) and in addition, the Crop / Retake buttons weren't pinned to the bottom of the screen. This is fixed by the first couple lines.
I also set the height / width constants not to be proportional to the screen size but fixed since that's what I generally prefer for this situation.
You'll need the following extension for the first few lines to work:
extension UIView {
func addConstraintsWithFormat(format: String, views: UIView...) {
var viewDict = [String: AnyObject]()
for (index, view) in views.enumerated() {
view.translatesAutoresizingMaskIntoConstraints = false
let key = "v\(index)"
viewDict[key] = view
}
addConstraints(NSLayoutConstraint.constraints(withVisualFormat: format, options: NSLayoutConstraint.FormatOptions(), metrics: nil, views: viewDict))
}
}
Owner
|
This fixes the crop frame when coming form camera but messes up frame even more when selecting from gallery. Need to study some more. |
Author
TBH, I use it for selecting from gallery. It should be mentioned that I create my layout in code and use AutoLayout. Maybe that's why we get different results? If I remember, I can quickly create a mini App tomorrow to show that it works in that case :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the iPhone X / XS, the cropView and fadeView were not perfectly on top of each other (offset in y direction) and in addition, the Crop / Retake buttons weren't pinned to the bottom of the screen. This is fixed by the first couple lines.
I also set the height / width constants not to be proportional to the screen size but fixed since that's what I generally prefer for this situation.
You'll need the following extension for the first few lines to work:
(it's generally a very helpful one)
Alternatively, you could use something like this in lines 106-108 (and don't have to use the extension):
It will also fix the iPhone X / XS bug.