Call this.resetRenderState() only once if dimension changed #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM (I've never fully groked the rendering code re canvas dimensions vs PDF.js dimensions, but this seems like an obvious improvement). The moving of lines 475-477 to 486-488 doesn't make any difference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpallen, can you do another small review here please?
Motivation for the change: If the viewport size changes, the
this.resetRenderState();should be called only once.PS: @jpallen is that okay if I ask you for review on these PR? I don't want you to feel comitted to do the reviews and force you in doing anything but your help here is highly appreciated :)