prevent BrokenResourceError message during normal stream connection teardown#257
prevent BrokenResourceError message during normal stream connection teardown#257evakhoni wants to merge 1 commit intojumpstarter-dev:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughException handling in the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
in #247, we're no longer suppressing BrokenResourceError, however during a normal stream connection teardown, the exception occurs with an BrokenPipeError which afaik is expected in this case, causing a warning that is repeated at the end of every connection over and over:
this PR is excluding the specific condition from the warning, while preserving other potentially useful messages.
discussed in #256
Summary by CodeRabbit