Introduces typed errors for tag parsing. #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tlm
commented
Oct 3, 2023
tlm
commented
- Upgrades juju/errors usage to v1 for ConstError support.
- Introduces a new typed error as part of Tag parsing.
- Changes the kind string error message to support the parsed tag error message.
- Upgrades juju/errors usage to v1 for ConstError support. - Introduces a new typed error as part of Tag parsing. - Changes the kind string error message to support the parsed tag error message.
hpidcock
reviewed
Oct 4, 2023
| func invalidTagError(tag, kind string) error { | ||
| if kind != "" { | ||
| return fmt.Errorf("%q is not a valid %s tag", tag, kind) | ||
| return fmt.Errorf("%q is %w of kind %s", tag, ErrorNotValid, kind) |
Member
There was a problem hiding this comment.
Can we use errors.Hide to keep the same error string, which would mean it reads better but also fulfils the requirement of errors.Is(_, ErrorNotValid) == true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.