Aborting when no valid files to push and clear log output#94
Open
ivantsepp wants to merge 1 commit intojstorimer:masterfrom
Open
Aborting when no valid files to push and clear log output#94ivantsepp wants to merge 1 commit intojstorimer:masterfrom
ivantsepp wants to merge 1 commit intojstorimer:masterfrom
Conversation
There are two consequences of this change. First, `files_to_load` will abort if there are no valid files. Before this change, spin would push to the server. Secondly, having `tty?` in the log output is a little confusing. This change makes the log output more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First consequence is that the log output will not include
tty?. Second consequence is thatspinwill correctly abort if there are no files to push.