fix(build): use calendar versioning for Sparkle update comparison #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use marketing version for both CFBundleVersion and CFBundleShortVersionString - Add custom GitSHA key to Info.plist for commit identification - Update SettingsView to display version as v2026.1.1 (abc123f) - Pass version to appcast script for sparkle:version element - Replace agvtool with direct xcodebuild build settings
jsattler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the version display issue where the app showed
1.0 (1607da0)instead of the correct version.Problem
agvtoolcommands weren't working because the project lacksVERSIONING_SYSTEM = apple-genericCFBundleVersion, but Sparkle requires incrementing/comparable version numbers for update comparisonsparkle:versionhardcoded to"1"Solution
MARKETING_VERSIONandCURRENT_PROJECT_VERSIONdirectly toxcodebuildinstead of usingagvtool2026.1.1) for bothCFBundleShortVersionStringandCFBundleVersionGitSHAkey to Info.plist for commit identification in the UISettingsViewto displayv2026.1.1 (abc123f)formatBUILD_NUMBERtoupdate_appcast.pyfor propersparkle:versionvalueResult
v2026.1.1 (abc123f)CFBundleShortVersionString2026.1.1CFBundleVersion2026.1.1sparkle:version2026.1.1Sparkle will now correctly compare semantic versions (e.g.,
2026.1.1vs2026.1.2) to determine if updates are available.