Fix null reference error in waitError when act.result is undefined#3
Open
wittjeff wants to merge 1 commit intojrpool:mainfrom
Open
Fix null reference error in waitError when act.result is undefined#3wittjeff wants to merge 1 commit intojrpool:mainfrom
wittjeff wants to merge 1 commit intojrpool:mainfrom
Conversation
The waitError function assumes act.result is already initialized, but this is not always the case. When a wait error occurs before act.result is set, the function crashes with: TypeError: Cannot set property 'found' of undefined This adds a nullish coalescing assignment to initialize act.result to an empty object if it's undefined before setting properties on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when
waitErroris called beforeact.resulthas been initialized.Problem
The
waitErrorfunction assumesact.resultalready exists:When a wait error occurs before
act.resultis set, this crashes with:Solution
Add a nullish coalescing assignment to initialize
act.resultif needed:Testing
This fix has been running in production at YRA Monitor via
patch-packagewithout issues.🤖 Generated with Claude Code