This repository was archived by the owner on May 4, 2018. It is now read-only.
Add interval and count to keep-alive#729
Open
jameshartig wants to merge 1 commit intojoyent:masterfrom
Open
Conversation
Author
|
According to the node docs "Setting 0 for initialDelay will leave the value unchanged from the default (or previous) setting.". So I've added the delay back to the if checks in tcp.c to keep that true. |
The default probe interval and failure counts set by the OS are too extreme. Lowering them will allow you to know when clients disconnect sooner, which is helpful if you're running a chat server.
|
Any updates on this? |
Contributor
|
@hertzg Looks like this fell through the cracks long time ago. The problem with this patch now is that it changes the API and thus it cannot land in v1.x. That aside, the values are not stored and thus lost if the socket was not yet created. There is a proposal to create sockets early: libuv/leps#5 which would simplify the problem, because the values can always be set. Either way, libuv moved over to https://github.com/libuv/libuv, so please open a new issue there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default probe interval and failure counts set by the OS are way too extreme and if you have a real-time socket server, you're going to want to customize these so you can have a much lower keep-alive interval and count so you're notified of disconnected sockets sooner.
Unfortunately, Windows doesn't let you set count, but using SIO_KEEPALIVE_VALS we can set interval (see: http://msdn.microsoft.com/en-us/library/windows/desktop/dd877220(v=vs.85).aspx). The defaults for the OS are 2 hour timeouts and 1 second intervals. I was hesitant about setting the default 1 second because that's pretty insane but decided just to leave it.