Open
Conversation
Adds support for .NET 6 DateOnly and TimeOnly types to parameter binding and deserialization.
Author
|
Third try had a typo in the branch name and could not verify all tests yesterday on my macbook. I think now everything should work as intended |
Owner
|
Awesome. I will do a review this week. And since I work off a macbook as well, my position is that I will build Windows-only/old versions but I won't verify them if there are low-risk changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for .NET 6+ DateOnly and TimeOnly types, resolving issue #534.
Changes
Files Modified
Testing
Backward Compatibility
Uses #if NET6_0_OR_GREATER conditional compilation to maintain compatibility with older frameworks.
Ensured that casts to TimeSpan and DateTime still work.
Build Verification
All changes have been verified to compile successfully