Mark dbus methods as unprivileged #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfhbrook
changed the title
Owner
Author
|
I can't run plusdeckd as sudo manually, I'm not sure why. I suspect it's because of a systemd restriction? Either way - I feel confident about this fix, and intend to test by releasing. But COPR builds for Python packages are still failing - I won't be able to test this until it's fixed. Still, I'm going to merge this as-is, and sort this out later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a commenter on my fedora board question, I think I've found the issue for #32!
It turns out that polkit was a red herring - the issue is that, when using the sdbus API, you need to mark the methods as being "unprivileged" with a flag!
I'm not sure how to best test this - I think the easiest thing might be to do a release and see? I'd also like to clean up the documentation, and get rid of the polkit stuff. But I'm confident that this is the answer!