fix: building the package’s dist files should *always* generate the build’s epoch as well, even when using the individual package goals only#950
Merged
jenstroeger merged 1 commit intomainfrom Sep 10, 2025
Conversation
…uild’s epoch as well, even when using the individual package goals only
Collaborator
|
I'm a bit confused because in dist: dist/$(PACKAGE_NAME)-$(PACKAGE_VERSION)-py3-none-any.whl dist/$(PACKAGE_NAME)-$(PACKAGE_VERSION).tar.gz dist/$(PACKAGE_NAME)-$(PACKAGE_VERSION)-docs-html.zip dist/$(PACKAGE_NAME)-$(PACKAGE_VERSION)-docs-md.zip dist/$(PACKAGE_NAME)-$(PACKAGE_VERSION)-build-epoch.txtwe already add the |
Owner
Author
|
Because make dist/package-v2.16.0-py3-none-any.whlor make dist/package-v2.16.0.tar.gzproduce the package artifacts but no epoch file, so that we end up with the package but we can’t reproduce it because we don’t know when that particular package file was created. |
behnazh
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that we can build an artifact but we won’t have the artifact’s build epoch timestamp:
This change fixes that issue:
We could probably make this more readable by using a dedicated
build-epochgoal or some such… 🤔This actually becomes useful in combination with PR #947 so that we can now use:
which builds the packages, their epoch, and the
pipSimple Repository.