Demux Github webhook events based on included regions#282
Open
salmaanrizvi wants to merge 17 commits intojenkinsci:masterfrom
Open
Demux Github webhook events based on included regions#282salmaanrizvi wants to merge 17 commits intojenkinsci:masterfrom
salmaanrizvi wants to merge 17 commits intojenkinsci:masterfrom
Conversation
…lean up old unused code
timja
reviewed
Feb 5, 2020
| @@ -0,0 +1 @@ | |||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.5.4/apache-maven-3.5.4-bin.zip No newline at end of file | |||
Member
There was a problem hiding this comment.
Would be good to make this a separate PR and use the latest version, 3.6.3 currently
Contributor
There was a problem hiding this comment.
@salmaanrizvi
I agree with @timja here. I'd rather the discuss the pros/cons of adding maven wrapper in another PR.
bitwiseman
reviewed
Apr 24, 2020
| import java.nio.channels.*; | ||
| import java.util.Properties; | ||
|
|
||
| public class MavenWrapperDownloader { |
bitwiseman
requested changes
Apr 24, 2020
Contributor
bitwiseman
left a comment
There was a problem hiding this comment.
@salmaanrizvi
This looks like an interesting and useful change, but it needs some changes.
- Merge with current master
- The maven wrapper addition needs to be a separate PR
- More comments either in the PR and or in the code for what the code is doing.
- Add tests
I've also started a gitter.im channel for this plugin. Happy to discuss over there as well.
Member
|
Is this not basically JENKINS-58637 and handled already by https://github.com/jenkinsci/multibranch-build-strategy-extension-plugin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the best way to do this, but would love to know of any cases / pitfalls I may have not considered properly in this implementation.