Allow setValueForKeyPath to create missing intermediate paths.#7
Open
robertjustjones wants to merge 1 commit intojeeeyul:masterfrom
Open
Allow setValueForKeyPath to create missing intermediate paths.#7robertjustjones wants to merge 1 commit intojeeeyul:masterfrom
robertjustjones wants to merge 1 commit intojeeeyul:masterfrom
Conversation
robertjustjones
force-pushed
the
set-when-target-missing
branch
from
6361be0 to
c70a34c
Compare
robertjustjones
force-pushed
the
set-when-target-missing
branch
from
ac4efd1 to
45974c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expected this to work, and it failed miserably when tried, so I've added it. The diff on the tests shows the new functionality.
I'm not sure if this is going strongly against your design intent, in which case it could be a separate command or an option to create missing targets.
I'm open to alternative implementations if you have suggestions.