Add AsyncIO Support for DCC Connection Handling#239
Open
smeinecke wants to merge 2 commits intojaraco:mainfrom
Open
Add AsyncIO Support for DCC Connection Handling#239smeinecke wants to merge 2 commits intojaraco:mainfrom
smeinecke wants to merge 2 commits intojaraco:mainfrom
Conversation
added 2 commits
February 15, 2025 16:31
- Add DCCProtocol class - Add AIODCCConnection class - Add dcc_connection_class in AIO Reactor TODO: implement listen/passive DCC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing with this library, I noticed that DCC connections are not managed using the asyncio library, which causes issues with DCC handling when using the asynchronous (AIO) version of the library.
This pull request introduces the following changes:
TODO: Implement listen/passive DCC functionality.