Use "node:" prefixed imports everywhere#250
Open
boenrobot wants to merge 2 commits intoisaacs:mainfrom
Open
Conversation
…version to the ones supporting this feature.
JDJD24-af
approved these changes
Sep 18, 2024
| v8 = require('node:v8') | ||
| } catch (er) {} | ||
|
|
||
| if (!v8 || !v8.getHeapStatistics || typeof v8.getHeapStatistics().number_of_detached_contexts !== 'number') { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows this package to be used with runtimes other than node, where node compatibility layer is provided for the prefixed imports (e.g.
workerd), at the cost of leaving behind older nodejs versions.Specifically, the required nodejs version would become ">=14.18.0 <15 || >=16".
CI is updated accordingly.
This PR also includes the first commit of #206. There was a conflict with master that's resolved, which is why the commit is unverified. The fallback introduced in that PR's second commit is not included, because given the version bump this PR requires, compatibility with those node versions is no longer needed.