Skip to content

Conversation

@benedikt-schaber
Copy link
Contributor

Motivation

In #957 I introduced two filters:

filters.cargoTomlConservative
filters.cargoTomlAggressive

However, pretty much all attention went to filters.cargoTomlConservative since you mentioned that that should be the default. Sadly, I thus overlooked, that the implementation I provided for filters.cargoTomlAggressive only keeps the top-level keys and so fails with any non-trivial test case.
I fixed that and ensured that now all filters are tested with all cleanCargoTomlTests test cases.

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

@benedikt-schaber
Copy link
Contributor Author

@ipetkov I did not update the changelog, since the filters are still unreleased

@ipetkov
Copy link
Owner

ipetkov commented Jan 24, 2026

Thanks for fixing this, sorry I missed it as well!

Yeah don't worry about the changelog I think its fine to omit an entry here

@ipetkov ipetkov merged commit c87c85e into ipetkov:master Jan 24, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants