Remove boost_system library dependency for Boost 1.89+ compatibility#350
Open
skulis wants to merge 1 commit intoipbus:masterfrom
Open
Remove boost_system library dependency for Boost 1.89+ compatibility#350skulis wants to merge 1 commit intoipbus:masterfrom
skulis wants to merge 1 commit intoipbus:masterfrom
Conversation
The boost_system compiled library was removed in Boost 1.89 (it has been header-only since Boost 1.69). Remove the linker dependency from uhal, tests, and python Makefiles to allow compilation with newer Boost versions.
tswilliams
force-pushed
the
remove_boost_system_dependency
branch
from
95518c9 to
5cb59d3
Compare
Collaborator
|
@skulis : Thanks for this PR. I'll trigger the CI now to see how this works with earlier boost releases. |
Collaborator
|
IPbusBot: Run tests, please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boost_system compiled library was removed in Boost 1.89 (it has been header-only since Boost 1.69). This PR removes the linker dependency on
-lboost_systemfrom several Makefiles. This allows the ipbus-software to compile with Boost 1.89+.Tested on up-to-date Arch Linux (Boost 1.89) with focus on uhal compilation. The build completes successfully after removing the boost_system library dependency. Not tested on any older systems or Boost versions.
Closes #349