[mock_uss] Make op_intent optional in mock_uss FlightRecord#1355
Open
BenjaminPelletier wants to merge 1 commit intointeruss:mainfrom
Open
[mock_uss] Make op_intent optional in mock_uss FlightRecord#1355BenjaminPelletier wants to merge 1 commit intointeruss:mainfrom
BenjaminPelletier wants to merge 1 commit intointeruss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, flight planning in mock_uss has a heavy assumption of being based solely on F3548-21 operational intents. To make mock_uss more flexibly enabling testing of other USS functions, we should move toward a general concept of a flight that may or may not happen to participate in F3548-21 strategic coordination (and/or CMSA). In particular, it would be far better to treat NetRID telemetry injection as injection of telemetry data for a flight than special stand-alone NetRID telemetry. This would enable USSs to, for instance, perform F3548-21 strategic coordination and F3411-22a NetRID for the same logical flight. As a consequence, the flight_planning interface could be used for both F3548-21 tests and for F3411-22a tests and the rid injection interface could be deprecated.
This PR takes a step in that direction by making mock_uss's FlightRecord.op_intent an optional field (since not all flights need operational intents -- for instance, flights participating only in F3411-22a and not in F3548-21).