[tooling] Add automatic database migration tests#1376
Open
the-glu wants to merge 1 commit intointeruss:masterfrom
Open
[tooling] Add automatic database migration tests#1376the-glu wants to merge 1 commit intointeruss:masterfrom
the-glu wants to merge 1 commit intointeruss:masterfrom
Conversation
0018c09 to
fa52c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, there are no automatic database migrations test.
There is indirect testing via CI, because we do apply then, but we don't verify that they can be down and that they do a correct cleanup, leading to human verifications to ensure everything is ok.
This PR add automatic migration tests that check:
This is not perfect (e.g. one can forgot to cover both datastore types), but should cover basic cases.
This also fix down migrations of yugabyte that where missing version set in two migration.