Refactor Context class: wire static manager properties to DI via ResolveManager#251
Merged
michaelbeale-IL merged 2 commits intomasterfrom Feb 21, 2026
Merged
Conversation
…er, improve thread safety, update docs Co-authored-by: michaelbeale-IL <63321611+michaelbeale-IL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Context class to remove static dependencies
Refactor Context class: wire static manager properties to DI via ResolveManager
Feb 21, 2026
michaelbeale-IL
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.ResolveManager<T>()existed as a DI-aware helper but was never called — all static manager properties read directly from theirLazy<T>singletons, makingContext.ServiceProviderhave no effect on property resolution.Changes
Context.csAppXxxstatic manager properties now delegate toResolveManager<T>()instead of reading_xxxManager.Valuedirectly — DI instances are used automatically whenServiceProvideris set, with transparent singleton fallback when notResolveManager<T>()andGetManager<TInterface>()by capturingServiceProviderto a local before useAppCommandManagerNo changes required at any of the 383+
Context.App*call sites — DI takes effect the momentContext.ServiceProvideris assigned.Documentation
DEPENDENCY_INJECTION_GUIDE.md: updated Context section to describe DI-aware property resolution and the adapter pattern rationaleACAT_MODERNIZATION_PLAN.md: added Phase 2 DI Infrastructure section reflecting completed state of issues Setup Service Container #209–Extension Loading with DI #216 (service container, Context refactor, interface extraction, factory pattern)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.