Skip to content

fix: input flag required for metrics trim command #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 1 commit into from
Jan 29, 2026
Merged

fix: input flag required for metrics trim command #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cmd/metrics/trim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ func init() {
trimCmd.Flags().IntVar(&flagTrimStartOffset, flagTrimStartOffsetName, 0, "seconds to skip from the beginning of the data")
trimCmd.Flags().IntVar(&flagTrimEndOffset, flagTrimEndOffsetName, 0, "seconds to exclude from the end of the data")

_ = trimCmd.MarkFlagRequired(flagTrimInputName) // error only occurs if flag doesn't exist

// Set custom usage function to avoid parent's usage function issues
trimCmd.SetUsageFunc(func(cmd *cobra.Command) error {
fmt.Fprintf(cmd.OutOrStdout(), "Usage:\n %s\n\n", cmd.UseLine())
Expand All @@ -83,6 +81,11 @@ func init() {

// validateTrimFlags checks that the trim command flags are valid and consistent
func validateTrimFlags(cmd *cobra.Command, args []string) error {
// Check that input flag was provided (required flag check)
if flagTrimInput == "" {
return workflow.FlagValidationError(cmd, "required flag \"--input\" not set")
}

// Check input file or directory exists
if _, err := os.Stat(flagTrimInput); err != nil {
if os.IsNotExist(err) {
Expand Down