Skip to content

fix: npm publish#33

Merged
patriksimek merged 1 commit intomainfrom
fix-npm-publish
Feb 6, 2026
Merged

fix: npm publish#33
patriksimek merged 1 commit intomainfrom
fix-npm-publish

Conversation

@patriksimek
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 6, 2026 22:28
@patriksimek patriksimek requested a review from a team as a code owner February 6, 2026 22:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package metadata and GitHub Actions workflow to improve npm publish reliability (including provenance) and refresh Node versions used in CI/publish.

Changes:

  • Bump package version to 0.10.2 and switch repository to the object form expected by some tooling.
  • Expand CI test matrix to include Node 24.
  • Update publish job permissions and publish command to include npm --provenance.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
package.json Bumps version and adjusts repository metadata format for npm publication.
.github/workflows/deploy-npm.yml Updates Node versions, adds OIDC permissions, and enables provenance for npm publish.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '22'
node-version: 24
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-version is typically provided as a string (and you already use strings in the matrix). Leaving it unquoted makes YAML treat it as a number, which can lead to subtle formatting/coercion issues. Consider using quotes for consistency, e.g. node-version: '24'.

Suggested change
node-version: 24
node-version: '24'

Copilot uses AI. Check for mistakes.
strategy:
matrix:
node-version: ['22', '20', '18']
node-version: ['24', '22', '20', '18']
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node version is defined in two places (matrix and publish job), and they’re currently inconsistent in representation (string list vs numeric). To avoid drift (e.g., bumping the matrix but forgetting publish), consider centralizing the publish Node version (e.g., via an env value reused in both places) or making publish run on a matrix entry.

Copilot uses AI. Check for mistakes.
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '22'
node-version: 24
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node version is defined in two places (matrix and publish job), and they’re currently inconsistent in representation (string list vs numeric). To avoid drift (e.g., bumping the matrix but forgetting publish), consider centralizing the publish Node version (e.g., via an env value reused in both places) or making publish run on a matrix entry.

Copilot uses AI. Check for mistakes.
@patriksimek patriksimek merged commit 6e8b3b9 into main Feb 6, 2026
4 checks passed
@patriksimek patriksimek deleted the fix-npm-publish branch February 6, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant