Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the package metadata and GitHub Actions workflow to improve npm publish reliability (including provenance) and refresh Node versions used in CI/publish.
Changes:
- Bump package version to 0.10.2 and switch
repositoryto the object form expected by some tooling. - Expand CI test matrix to include Node 24.
- Update publish job permissions and publish command to include npm
--provenance.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Bumps version and adjusts repository metadata format for npm publication. |
| .github/workflows/deploy-npm.yml | Updates Node versions, adds OIDC permissions, and enables provenance for npm publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 | ||
| with: | ||
| node-version: '22' | ||
| node-version: 24 |
There was a problem hiding this comment.
node-version is typically provided as a string (and you already use strings in the matrix). Leaving it unquoted makes YAML treat it as a number, which can lead to subtle formatting/coercion issues. Consider using quotes for consistency, e.g. node-version: '24'.
| node-version: 24 | |
| node-version: '24' |
| strategy: | ||
| matrix: | ||
| node-version: ['22', '20', '18'] | ||
| node-version: ['24', '22', '20', '18'] |
There was a problem hiding this comment.
The Node version is defined in two places (matrix and publish job), and they’re currently inconsistent in representation (string list vs numeric). To avoid drift (e.g., bumping the matrix but forgetting publish), consider centralizing the publish Node version (e.g., via an env value reused in both places) or making publish run on a matrix entry.
| uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 | ||
| with: | ||
| node-version: '22' | ||
| node-version: 24 |
There was a problem hiding this comment.
The Node version is defined in two places (matrix and publish job), and they’re currently inconsistent in representation (string list vs numeric). To avoid drift (e.g., bumping the matrix but forgetting publish), consider centralizing the publish Node version (e.g., via an env value reused in both places) or making publish run on a matrix entry.
No description provided.