Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
=====================================
Coverage 25% 25%
=====================================
Files 25 25
Lines 1688 1686 -2
=====================================
Hits 421 421
+ Misses 1267 1265 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Technically speaking, this will trigger a new major version ( Could you explain the idea / reason in the PR in a few words please? |
Contributor
Author
|
Certainly :) The original function does not work as it is missing several parameters. |
ehrenfeu
requested changes
Jan 14, 2026
This was referenced Jan 14, 2026
Merged
Contributor
Author
|
Closed this PR because it will be merged with #118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original function does not work as it is missing several parameters.