Added IBufferedFileStream - a faster variant of IFileStream designed …#6
Open
intorr wants to merge 2 commits intoianpatt:masterfrom
Open
Added IBufferedFileStream - a faster variant of IFileStream designed …#6intorr wants to merge 2 commits intoianpatt:masterfrom
intorr wants to merge 2 commits intoianpatt:masterfrom
Conversation
…for working with small files such as kosaves.
Owner
|
Thank you for the submission - this is interesting, but I'd need to rewrite it as you mentioned. Rather than a combination buffer-writer and file-writer, just have a std::vector-backed buffer stream, write to that, then write that stream to a file. |
…ileStream for reading/writing.
Author
|
Like this? Rewrote IBufferedFileStream - now using std::vector and a separate IFileStream for reading/writing. |
Author
|
Tested for over two months. Didn't find any errors, works well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for working with small files such as kosaves.
Now when using plugins that save a lot of small chunks in the kosave, the saving itself is very slow.
For example, for Skyrim AE, when using the RaceMenu plugin, saving specific plugin data takes about 2 seconds.
If you use the new class, this time is reduced to 50 milliseconds.
I'm not very good at writing C++, but maybe this or a similar change should be made to make saving much faster?
Paired pull request for ianpatt/skse64#44