Skip to content

⚡ Bolt: Refactor IconifyIcon to remove bundled icon sets #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshahriazz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Refactor IconifyIcon to remove bundled icon sets #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Bolt's Journal

## 2024-05-22 - [Bundle Size Bloat from Iconify]
**Learning:** The `IconifyIcon` component was importing entire icon sets (JSON files) statically, resulting in a ~9MB main bundle. This defeats the purpose of code splitting and significantly hurts initial load time.
**Action:** Use `@iconify/react`'s default fetching mechanism or dynamic imports for collections. Avoid importing full icon datasets in the main bundle.
44 changes: 2 additions & 42 deletions apps/client/src/components/base/IconifyIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,4 @@
import { icons as entypoSocialIcons } from "@iconify-json/entypo-social";
import { icons as evaIcons } from "@iconify-json/eva";
import { icons as fa6Brands } from "@iconify-json/fa6-brands";
import { icons as flagIcons } from "@iconify-json/flag";
import { icons as icIcons } from "@iconify-json/ic";
import { icons as materialIcons } from "@iconify-json/material-symbols";
import { icons as materialLightIcons } from "@iconify-json/material-symbols-light";
import { icons as mdiIcons } from "@iconify-json/mdi";
import { icons as mdiLightIcons } from "@iconify-json/mdi-light";
import { icons as riIcons } from "@iconify-json/ri";
import { icons as twemojiIcons } from "@iconify-json/twemoji";
import { Icon, IconifyJSON, IconProps } from "@iconify/react";
import { getIconData } from "@iconify/utils";
import { Icon, IconProps } from "@iconify/react";
import { Box, BoxProps } from "@mui/material";

interface IconifyProps extends IconProps {
Expand All @@ -19,34 +7,6 @@ interface IconifyProps extends IconProps {
icon: string;
}

const iconSets: Record<string, IconifyJSON> = {
"material-symbols": materialIcons,
"material-symbols-light": materialLightIcons,
twemoji: twemojiIcons,
eva: evaIcons,
ri: riIcons,
ic: icIcons,
flag: flagIcons,
"fa6-brands": fa6Brands,
"entypo-social": entypoSocialIcons,
mdi: mdiIcons,
"mdi-light": mdiLightIcons,
};

const iconData = (icon: string) => {
const [prefix, name] = icon.includes(":") ? icon.split(":") : ["", icon];

if (prefix && iconSets[prefix]) {
const data = getIconData(iconSets[prefix], name);
if (data) return data;
}

for (const [_, icons] of Object.entries(iconSets)) {
const data = getIconData(icons, name);
if (data) return data;
}
};

const IconifyIcon = ({
icon,
flipOnRTL = false,
Expand All @@ -56,7 +16,7 @@ const IconifyIcon = ({
return (
<Box
component={icon ? Icon : "span"}
{...(icon ? { icon: iconData(icon), ssr: true } : ({} as any))}
{...(icon ? { icon, ssr: true } : ({} as any))}
className='iconify'
sx={[
flipOnRTL && {
Expand Down