Just prevent TypeError: Cannot read property 'constructor' of undefined#235
Open
jasonxia23 wants to merge 2 commits intohueitan:masterfrom
jasonxia23:master
Open
Just prevent TypeError: Cannot read property 'constructor' of undefined#235jasonxia23 wants to merge 2 commits intohueitan:masterfrom jasonxia23:master
TypeError: Cannot read property 'constructor' of undefined#235jasonxia23 wants to merge 2 commits intohueitan:masterfrom
jasonxia23:master
Conversation
Contributor
|
please update both the sources and create the dist and minified dist files using the build task and squash your commits. But I actually think the solution should be in the checkValidation function itself.. I think it should always return either error or success, never undefined. This is my proposal: #241 |
Owner
|
yes, there is no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just prevent
TypeError: Cannot read property 'constructor' of undefined