Ports over fix from autover/pull/67 to param#469
Merged
philippjfr merged 3 commits intomasterfrom May 13, 2021
Merged
Conversation
Contributor
Author
|
There is one failing test on pypy2 but that seems unrelated to the PR (some failure regarding numpy). |
Contributor
Author
|
@jbednar happy to merge given the test failure is unrelated? |
Member
|
Yes, this PR can be merged, but we have to do something about the failing test, and may as well do it before merging this. Can we e.g. remove pypy on 2.7 from the test matrix? I'm happy to stop testing that configuration; it's not one we advertise and I don't want us to have to do work to support it. |
Member
|
Dropped pypy2, will merge once passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the fixed git remote check implemented in holoviz-dev/autover#67 to
param.Versiontoaddress #468. The longer terms fix is in holoviz-dev/autover#66 which will be merged once the test failures are resolved.