Fix Shop_GiveClientItem (probably unfinished, need tests)#112
Fix Shop_GiveClientItem (probably unfinished, need tests)#112RusJJ wants to merge 5 commits intohlmod:masterfrom
Conversation
Bump version
Fixed for the latest version of SteamWorks
PROBABLY unfinished Fixes Shop_GiveClientItem by handling third param named "count"
Revert one change in a code
TiBarification
left a comment
TiBarification
left a comment
There was a problem hiding this comment.
Which version of Steamworks you're using? Your changes fails by CI/CD not only on SM 1.11 build (which is allowed to fail), but also on SM 1.10 build.
https://app.travis-ci.com/github/FD-Forks/Shop-Core/jobs/553970168
|
|
||
| /* Stats pusher */ | ||
| public int SteamWorks_SteamServersConnected() | ||
| public void SteamWorks_SteamServersConnected() |
There was a problem hiding this comment.
no need to change it
| public void SteamWorks_SteamServersConnected() | ||
| { | ||
| int iIp[4]; | ||
| char iIp[4]; |
There was a problem hiding this comment.
same here, why you have changed it
|
Why you're using this fork instead of original repository? Also i see this fork is marked as "read-only", I don't think it have any support. For building we're use http://users.alliedmods.net/~kyles/builds/SteamWorks/ builds and |
|
@RusJJ please take a look into https://github.com/FD-Forks/Shop-Core/blob/master/.travis.yml file, there are instructions for compilation shop core. |
2 participants
No description provided.