Runtime rewrite for handlers #389
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I have experimented with preallocating a fixed size for the array and it yields mixed result. Presumably the extra memory usage of the array might cause extra gc overhead from scanning the array. |
Author
|
As a side note, will it be a good idea to have the benchmark part of #335 merged before the rest of the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the runtime to make use of an array instead of allocating a new object for each frame. Some benchmark is necessary before this PR is ready since this is meant to improve the performance. Using a separate
Uint32Arrayto store integer values in the array may yield further improvement as it will further reduce gc overhead, but at a cost of a more complicated unwind implementation.