Open
Conversation
Owner
|
Hi, thank you so much for this! I just unbroke the build in master, so if you rebase, the tests should pass. Some thoughts – let me know what you think.
If you feel like it, a test would be really nice, but I've been lax about it elsewhere in this project, so I don't consider it a must at this point :) |
Author
|
Sorry for delaying my answer. Indeed About the docs, you may be the most fit one to do so can you do it? hehe How about using: %{"episode" => episode} = Regex.named_captures(~r/^(?<episode>\d{3})/, "123_foo_bar") |
Owner
|
Sure, happy to fix the docs :) I can do that after merging. Yeah, anchoring the regex to the beginning of line like that seems like a good idea. Go for it! |
* Rename --start parameter to --start-from-episode * Use Regex to match the first episode and reject the ones before it
Author
|
About the tests I'm not sure how I'm going to test the runner with Auth and stuff :x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works for both oldest and latest runnings ;)