Add bucket and other info to AWS errors #1123
Merged
+111
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
requested review from
bbalser,
connormck333,
jeffgrunewald and
kurotych
When you have multiple file_info_pollers running and one of them may be misconfigured, it is difficult to tell from (usually) the `ListObjectsV2Error` which poller is failing. This PR adds the bucket and file key or prefix for the operation that was being attempted. Adding the extra information bumps the Err size to 216 bytes, so we box it to keep from tripping clippy’s `result_large_err` lint.
We no longer have to deal with tonic’s large err variants in file-store. So we can remove this allowance.
michaeldjeffrey
force-pushed
the
mj/file-store-aws-err-info
branch
from
d1d3541 to
13da6bd
Compare
Even though this will go away soon
michaeldjeffrey
force-pushed
the
mj/file-store-aws-err-info
branch
from
385481b to
7e20fae
Compare
bbalser
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have multiple file_info_pollers running and one of them may be misconfigured, it is difficult to tell from (usually) the
ListObjectsV2Errorwhich poller is failing.This PR adds the bucket and file key or prefix for the operation that was being attempted.
clippy.tomlhas been removed now that we no longer handle tonic err variants in file-store.AwsErrorto keep from trippingclippy:result_large_errfor a variant that is 216 bytes with the new information.