Removing unallocated rewards

[connormck333]

With the current rewarding, depending on the total epoch emissions there may be a bone unaccounted for due to rounding. Currently, we write an unallocated reward for unaccounted for bones during poc rewarding. We do not write unallocated rewards for service providers because the full amount is rewarded. In total, this accounts for 94% of the total epoch emissions.

If the poc unallocated amount is less than 1, it will not be written. The problem is that when we calculate the reward amount for service providers, we round to 0, which could dismiss 0.8 of a bone. If we are dismissing 0.6 of a bone during poc rewarding, and dismissing 0.8 of a bone during service provider rewarding, we then have 1.4 bones that are unaccounted for.

Example:

Total epoch emissions 82191780821915

poc and dc rewards: 57534246575340
sp: 19726027397259

poc unallocated: 0.5
sp unallocated: 0.6 (both less than 0 so no unallocated reward written)

result: 77260273972599
94%: 77260273972600.1

Missing 1.1 bones

In this PR, I have moved the writing of unallocated rewards out of poc. Now we calculate the difference between 94% of total rewards and the allocated poc and dc rewards which is to be rewarded to service providers.

[connormck333]

Revert

[michaeldjeffrey]

I'd like to see if we can tighten some of this up.

• get_scheduled_verifier_tokens() :: not sure I follow the name of this function. And I think the switch to returning to u64 from Decimal is something we need to discuss.

• reward_service_providers() :: There should be any poc or dc related math going on in this function.

• reward_dc() :: it's a bit confusing to me that we're returning both sides of what was allocated from this function, but in different types.

• reward_poc() :: returning the 3-tuple is hard to read. And confusing when you follow function calls up a single level and some form of the same return tuple is present but in a different order.

Also wondering if we still need to be committing speedtest_averages during rewards?