Skip to content

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Feb 4, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes ontology/OMN generation functionality from this repository, retaining only HED ID utilities and pointing users to the separate hed-ontology repo for ontology-related operations.

Changes:

  • Extracted HED ID range, assignment, and validation logic into a new hed_id_util module and updated all call sites and tests to use it.
  • Removed ontology-related code and tooling (ontology_util, create_ontology script, CLI entry point, and related tests).
  • Updated documentation to remove ontology-generation steps from the release workflow and direct users to the hed-ontology repository.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/schema/test_hed_id_util.py Redirects tests from ontology_util to the new hed_id_util module and removes tests for now-removed OMN conversion, ensuring HED ID utilities remain covered.
pyproject.toml Removes the hed_create_ontology console script entry, aligning available CLI commands with the removal of ontology functionality.
hed/scripts/hed_convert_schema.py Switches to hed_id_util.update_dataframes_from_schema, preserving schema update behavior while decoupling from ontology conversion.
hed/scripts/create_ontology.py Deletes the ontology-creation script, fully removing ontology generation from this codebase.
hed/schema/schema_io/ontology_util.py Removes the ontology/OMN conversion utilities now moved to hed-ontology, avoiding dead or duplicated functionality.
hed/schema/schema_io/hed_id_util.py Introduces a focused utility module for HED ID range computation, validation, and assignment, preserving existing behavior without ontology concerns.
hed/schema/schema_attribute_validator_hed_id.py Updates the get_library_data import to use hed.schema.hed_cache directly, reflecting the removal of ontology_util.
docs/user_guide.md Updates schema release best-practices to drop ontology generation steps and adds a note that OMN/OWL generation is now handled in the hed-ontology repository.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VisLab VisLab merged commit d67e599 into hed-standard:main Feb 4, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant