V1.2.7 && v1.2.8 Helm chart addition#59
V1.2.7 && v1.2.8 Helm chart addition#59ravi100k wants to merge 6 commits intohammer-space:masterfrom
Conversation
ravi100k
force-pushed
the
v1.2.7(use-bind-mount)
branch
from
c24b771 to
a8dfbe6
Compare
ravi100k
changed the title
|
@ravi100k I asked Trond and Luis Pabon to review this Pull Request. And some of the comments that came back was that there wasn't enough contextual information regarding the changes that have been made...and it's quite a large PR to just approve without that context. I'm wondering if we might be able to either ask you to provide more context for this PR and/or could we all get together and have a PR review meeting to just address all of the questions? Thanks... |
V1.2.7 added node bind mount to reduce api calls. V1.2.7 added helm chart to deploy V1.2.7 added heml package V1.2.7 added heml package V1.2.7 added repo tz file, added readme file
1. Reverted some non usefull changes. Will add up in v1.2.8.
ravi100k
force-pushed
the
v1.2.7(use-bind-mount)
branch
from
88d8546 to
b681528
Compare
ravi100k
changed the title
deploy/helm/README.md
Outdated
|
|
||
| 2. **Install the chart into your cluster:** | ||
| ``` | ||
| helm install hscsi hscsi/ --namespace kube-system --create-namespace |
There was a problem hiding this comment.
There should be instructions on how to create and use values.yml from a user point of view
There was a problem hiding this comment.
Update this document as well as added developer .md file for creating new package
lpabon
left a comment
lpabon
left a comment
There was a problem hiding this comment.
I have approved it, but please have QA test it before merging
4 participants
No description provided.