Fix/halter multiplug instantiation#14
Merged
uh-oh-monteiro merged 4 commits intohalter-modsfrom Jul 25, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 16510796558Details
💛 - Coveralls |
callumgilbert
approved these changes
Jul 25, 2025
jonny12375
approved these changes
Jul 25, 2025
jonny12375
reviewed
Jul 25, 2025
| self.tear_down_plugs() | ||
| raise | ||
| self.update_plug(plug_type, plug_instance) | ||
| self.update_plug(plug_type, plug_instance) |
There was a problem hiding this comment.
imo i think the actual fix is to not call update_plug in add_non_managed_plug and tear_down_plugs for the unmanaged plugs, but this theoretically does the same thing. We might run into some edge case later on because the non-managed plugs are added to plugs_by_type and _by_name earlier than the managed plugs, but it's probably fine
Author
There was a problem hiding this comment.
I'll try to implement when I've got more time :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.