Fix tracing parentage hierarchy #8919
Open
+180
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The failures are now due to the interaction between tracing and GPU libraries. I'm not sure this was covered before adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
parent_idproperty of tracing packets to point upwards in a stack trace of realizations, produce nodes, and consume nodes.I tested this against our existing, but limited, unit tests, and on the local_laplacian app.
The above visualization was rendered by an in-development tool that reconstructs the func dataflow DAG from the trace using the corrected lineage semantics. The tool uses GraphViz to compute a layout.
Fixes #8917