Standardize error message formatting #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes all error messages lowercase and adds attribute context to type errors for consistency with Ruby conventions and improved debugging. Changes: - Lowercase error messages: "cannot specify..." instead of "Cannot specify..." - Add attribute name to type errors: "cannot specify X as type for :attr" - Catch and re-raise ArgumentError in Builder#coercions to add context - Update tests to match new error message format Closes #16 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes all error messages to use lowercase for consistency with Ruby conventions and improves type error messages to include attribute names for easier debugging.
Changes
Error Message Standardization:
"Cannot specify both type and block for :name"→"cannot specify both type and block for :name""Cannot specify X as type"→"cannot specify X as type for :attr"Implementation:
Builder#coercionsto catch and re-raiseArgumentErrorwith attribute contextBefore/After
Before:
After:
Now developers immediately know which attribute has the invalid type!
Testing
Closes #16
🤖 Generated with Claude Code