Message port close events channel after all the sender routines exited#6
Open
magodo wants to merge 2 commits intohack-pad:mainfrom
Open
Message port close events channel after all the sender routines exited#6magodo wants to merge 2 commits intohack-pad:mainfrom
events channel after all the sender routines exited#6magodo wants to merge 2 commits intohack-pad:mainfrom
Conversation
When the context of the `Listen()` being canceled. There is a race condition that the goroutine that closes the `events` channel runs prior than the other handler goroutines (for both `message`/`messageerror`). If this happens, those handler goroutines will panic as the `events` channel is closed, and sending to a closed channel just panics in Go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the context of the
Listen()being canceled. There is a race condition that the goroutine that closes theeventschannel runs prior than the other handler goroutines (for bothmessage/messageerror). If this happens, those handler goroutines will panic as theeventschannel is closed, and sending to a closed channel just panics in Go.