feat: Implement a PDF conversion script #2466 #2467
Draft
shaunyogeshwaran wants to merge 8 commits intomainfrom
Draft
feat: Implement a PDF conversion script #2466 #2467shaunyogeshwaran wants to merge 8 commits intomainfrom
shaunyogeshwaran wants to merge 8 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| while (nextPageUrl) { | ||
| if (urls.length >= maxPages) break; | ||
| if (urls.includes(nextPageUrl)) break; |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 months ago
To address the issue, we need to validate that nextPageUrl belongs to the trusted domain (docs.h2o.ai) before adding it to the urls array. This can be achieved by parsing the URL using the URL constructor and checking its hostname property against the trusted domain. This approach ensures that only URLs with the correct host are processed, mitigating the risk of malicious URLs bypassing the check.
The changes will involve:
- Parsing
nextPageUrlusing theURLconstructor. - Validating that the
hostnameofnextPageUrlmatches the trusted domain (docs.h2o.ai). - Updating the condition on line 16 to include this validation.
Suggested changeset
1
docs-pdf/generate-pdf.js
| @@ -15,3 +15,9 @@ | ||
| if (urls.length >= maxPages) break; | ||
| if (urls.includes(nextPageUrl)) break; | ||
| try { | ||
| const parsedUrl = new URL(nextPageUrl); | ||
| if (parsedUrl.hostname !== 'docs.h2o.ai' || urls.includes(nextPageUrl)) break; | ||
| } catch (e) { | ||
| console.error(`Invalid URL encountered: ${nextPageUrl}`); | ||
| break; | ||
| } | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2466
This PR is still a WIP and not yet ready for review
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.