fix: Failing h2o_wave installation when building the tour image#2289
Open
sulhicader wants to merge 9 commits intomainfrom
Open
fix: Failing h2o_wave installation when building the tour image#2289sulhicader wants to merge 9 commits intomainfrom
sulhicader wants to merge 9 commits intomainfrom
Conversation
5 tasks
mturoci
requested changes
Mar 14, 2024
Collaborator
mturoci
left a comment
mturoci
left a comment
There was a problem hiding this comment.
Thanks @sulhicader. This changes the whole bundle
.github/workflows/release-wave.yml
Outdated
Comment on lines
169
to
176
| - name: Copy H2O Wave wheel | ||
| run: | | ||
| cp py/h2o_wave/dist/h2o_wave-${{ env.VERSION }}-py3-none-manylinux1_x86_64.whl ./py/tmp/tour/ | ||
|
|
||
| - name: Edit Requirements file | ||
| working-directory: ./py/apps/tour/ | ||
| run: sed -i -r -e "s/h2o_wave==\{\{VERSION\}\}/h2o_wave-${{ env.VERSION }}-py3-none-manylinux1_x86_64.whl/g" requirements.txt | ||
|
|
Collaborator
There was a problem hiding this comment.
Can this be moved into wave-bundle actions instead? Also please add a comment explaining why it's needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Fixes #2288