test: Decimal support Progress Table Cell Type #824#2226
Open
modhurimaroy wants to merge 1 commit intoh2oai:mainfrom
Open
test: Decimal support Progress Table Cell Type #824#2226modhurimaroy wants to merge 1 commit intoh2oai:mainfrom
modhurimaroy wants to merge 1 commit intoh2oai:mainfrom
Conversation
Collaborator
|
Hi @modhurimaroy, there is no need for a new param. The goal of the issue is to render a decimal value if provided (it's currently rounded), otherwise display an integer as today. Make sure there are max 2 decimal. places. |
Collaborator
|
Also please close the other PR so that we do not have duplicates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #824, introduces an optional parameter for including decimal values in Progress Table Cell Type, and includes new test cases to ensure the new feature is functional.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.