feat: Add trigger_on_enter parameter to ui.inline #372#1744
Open
sherrychen2 wants to merge 3 commits intoh2oai:mainfrom
Open
feat: Add trigger_on_enter parameter to ui.inline #372#1744sherrychen2 wants to merge 3 commits intoh2oai:mainfrom
sherrychen2 wants to merge 3 commits intoh2oai:mainfrom
Conversation
mturoci
reviewed
Dec 9, 2022
Collaborator
mturoci
left a comment
There was a problem hiding this comment.
Thanks @sherrychen2. We need to discuss this with @lo5 and get back to you, but the implementation will most likely need to be adhered to #348 (comment) instead of introducing a new trigger_on_enter attr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
trigger_on_enterparameter toui.inlinethat allows users to press the Enter key to submit the form intextbox.tsx.The feature is showcased in
textbox.pyby adding aui.textboxthat submits when pressing the Enter key:Screenshot.2022-12-08.at.22.16.39.mov
Unit tests were added in
textbox.test.tsxas follows:Closes #372.