Add new endpoint to move children of a dataset resource into a workspace folder#529
Draft
philmcmahon wants to merge 3 commits intomainfrom
Draft
Add new endpoint to move children of a dataset resource into a workspace folder#529philmcmahon wants to merge 3 commits intomainfrom
philmcmahon wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Currently if we want to add stuff to a workspace we have to either upload it directly to the workspace via the UI or to add files one by one from the dataset view.
Right now we have a lot of files to put into giant, it's a shame to be held back by the speed of UI uploads. With that in mind, this PR adds a new endpoint that will get all the File children of a particular resource and create WorkspaceNode nodes for each of them in neo4j, with a parent of a specified workspace folder.
This is a bit of a half arsed solution to what should be a 'Add Resource to workspace' functionality, but it provides a short term fix to the problem of wanting to add thousands of files at a time to a workspace.
How has this change been tested?
I've tested this locally, it needs doing on playground