Open
Conversation
8a18535 to
3c894ee
Compare
Closed
3c894ee to
7feaf2d
Compare
twrichards
approved these changes
Jan 28, 2026
Contributor
twrichards
left a comment
There was a problem hiding this comment.
LGTM (we're so 'cutting edge')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
There's no real urgency with this change as corretto 11 is supported until 2032 but I wanted to add https://github.com/guardian/play-brotli-filter to giant, and that only supports java 21, so I'm moving giant onto java 21.
Changes:
Getting this to work locally: this depends how you're managing java on your machine. I use https://github.com/jenv/jenv so I had to do:
brew install --cask corretto@21jenv add /Library/Java/JavaVirtualMachines/amazon-corretto-21.jdk/Contents/Homejenv versionsNote - this can't be released until we've fixed our AMI bakes
How to test
I've tested this on playground using this AMI: https://amigo.gutools.co.uk/recipes/investigations-giant-app-arm-j21/bakes/1