Open
Conversation
Contributor
|
Thanks for this @komachi! We'll go through this PR this week. At a quick glance looks like a whole bunch of very helpful changes, we'll just need to review to check for compatibility with our production cluster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
I wanted to compare giant with aleph and datashare and found it's pretty hard to run giant, so I made a Dockerfile for it to run everything with single command.
How to test
Run
docker compose upin root, then visit http://localhost:9001Have we considered potential risks?
I also fixed package-lock in frontend (it missed hash for one dep so it was not installable with npm ci, also I run npm audit fix and updated caniuse-lite db).
For postgres/migrate-db, I added postgrator-cli to run migration easily and without custom script.
Also I made docker image with java17 because it's default java in debian bookworm (current stable), this forced me to remove some deprecated cli opts not supported anymore in java17. If you still need it to run on java11 with this options, should they be moved somewhere else?
Some config options also became configurable via ENV and default endpoints changed from localhost to docker-compose hosts.
Deps in docker-compose were updated to latest non-breaking change.