refactor: comparison operators for IStat interface #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenstack
requested changes
Jul 9, 2025
Owner
greenstack
left a comment
greenstack
left a comment
There was a problem hiding this comment.
Thanks for doing this, and sorry it's taken me so long to get to this review! I'd like to retain the comparison operators between stats as well. That way the ability to do direct comparisons between stats is retained.
Contributor
Author
|
I was getting some errors trying to change these operators in IStat interface. Because of that, I moved all of them to the ResourceStat class. |
greenstack
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #6