feat: clone schema #697
Open
feat: clone schema #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to clone a GraphQL schema with a new resolver and apply a resolver to a schema that was created without one. These features enable multi-tenant scenarios and deferred resolver binding patterns.
Changes:
- Added
CloneandMustClonemethods to create schema copies with different resolvers and options - Added
ApplyResolvermethod to attach a resolver to a nil-resolver schema (can only be called once) - Added
sync.Mutexto the Schema struct for thread-safe resolver application - Added comprehensive test coverage for cloning, resolver application, concurrency, and multi-tenant scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| graphql.go | Implements Clone, MustClone, and ApplyResolver methods with mutex for concurrency safety |
| graphql_test.go | Adds extensive tests for schema cloning, resolver application, concurrency, and multi-tenant use cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pavelnikolov
force-pushed
the
001-schema-clone-resolver
branch
from
9cece25 to
fff7573
Compare
pavelnikolov
force-pushed
the
001-schema-clone-resolver
branch
from
fff7573 to
261b6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow cloning of a schema with a new resolver. Also allow applying a resolver to a schema without one.